a2l007 commented on code in PR #13358:
URL: https://github.com/apache/druid/pull/13358#discussion_r1023403531
##########
server/src/main/java/org/apache/druid/discovery/DiscoveryDruidNode.java:
##########
@@ -164,6 +179,12 @@ public DruidNode getDruidNode()
return druidNode;
}
+ @JsonProperty
+ public DateTime getStartTime()
+ {
+ return startTime;
+ }
Review Comment:
Since a DiscoveryDruidNode object is primarily identified by its DruidNode,
role and the service map, I wanted to preserve the equality condition. Also,
start_time might not be a concrete enough to decide the equality between two
DiscoveryDruidNode objects, if the other field values are the same. What do you
think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
