vogievetsky commented on code in PR #13358:
URL: https://github.com/apache/druid/pull/13358#discussion_r1024359499
##########
web-console/src/views/services-view/services-view.tsx:
##########
@@ -67,14 +67,25 @@ const allColumns: string[] = [
'Current size',
'Max size',
'Usage',
+ 'Start time',
'Detail',
ACTION_COLUMN_LABEL,
];
const tableColumns: Record<CapabilitiesMode, string[]> = {
'full': allColumns,
'no-sql': allColumns,
Review Comment:
ok, so since you are not updating `/druid/coordinator/v1/servers?simple` you
should make sure that `Start time` is no in the `no-sql` column list. `no-sql`
is the mode used when the user had no SQL access so it falls back to the old
endpoint. You should set `no-sql` to:
```
[
'Service',
'Type',
'Tier',
'Host',
'Port',
'Current size',
'Max size',
'Usage',
'Detail',
ACTION_COLUMN_LABEL,
];
```
Also at this point you can inline the `allColumns` constant as it's reasons
for existence was to set `full` and `no-sql` to the same thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
