LakshSingla commented on code in PR #13353: URL: https://github.com/apache/druid/pull/13353#discussion_r1023528416
########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/RetryTask.java: ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.msq.indexing; + +import org.apache.druid.msq.indexing.error.MSQFault; + +public interface RetryTask Review Comment: I think this would be better named as `RelaunchTask` if we are going with relaunch instead of retry everywhere. WDYT? ########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQWorkerTaskLauncher.java: ########## @@ -507,5 +689,23 @@ public boolean didRunTimeOut(final long maxTaskStartDelayMillis) && unknownLocation() && System.currentTimeMillis() - startTimeMs > maxTaskStartDelayMillis; } + + /** + * Enables retrying for the task + */ + public void enableRetrying() Review Comment: ```suggestion public void enableRelaunching() ``` ########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQWorkerTask.java: ########## @@ -58,11 +61,12 @@ public MSQWorkerTask( @JsonProperty("controllerTaskId") final String controllerTaskId, @JsonProperty("dataSource") final String dataSource, @JsonProperty("workerNumber") final int workerNumber, - @JsonProperty("context") final Map<String, Object> context + @JsonProperty("context") final Map<String, Object> context, + @JsonProperty(value = "retry", defaultValue = "0") final int retryCount Review Comment: ```suggestion @JsonProperty(value = "relaunch", defaultValue = "0") final int relaunchCount ``` I think we should drop retry in favour of relaunch (or change everything back to retry) to avoid confusion unless they mean different things. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
