cryptoe commented on code in PR #13353: URL: https://github.com/apache/druid/pull/13353#discussion_r1033558947
########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/error/MSQFaultUtils.java: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.msq.indexing.error; + +public class MSQFaultUtils +{ + + public static final String ERROR_CODE_DELIMITER = ": "; + + /** + * Generate string message with error code delimited by {@link MSQFaultUtils#ERROR_CODE_DELIMITER} + */ + public static String generateMessageWithErrorCode(MSQFault msqFault) + { + final String message = msqFault.getErrorMessage(); + + if (message != null && !message.isEmpty()) { + return msqFault.getErrorCode() + ERROR_CODE_DELIMITER + message; + } else { + return msqFault.getErrorCode(); + } + } + + /** + * Gets the error code from the message. If the messay is empty or null, {@link UnknownFault#CODE} is returned. This method + * does not gurantee that the error code we get out of the message is a valid error code. + */ + public static String getErrorCodeFromMessage(String message) Review Comment: Umm, I do not think so as task status might be received from the tasks table where the status calls are chomped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
