adarshsanjeev commented on code in PR #13205:
URL: https://github.com/apache/druid/pull/13205#discussion_r1025073031
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/kernel/controller/ControllerStageTracker.java:
##########
@@ -259,16 +257,21 @@ ControllerStagePhase addResultKeyStatisticsForWorker(
}
try {
- if (workersWithResultKeyStatistics.add(workerNumber)) {
- resultKeyStatisticsCollector.addAll(snapshot);
+ if (workersWithReportedKeyStatistics.add(workerNumber)) {
- if (workersWithResultKeyStatistics.size() == workerCount) {
- generateResultPartitionsAndBoundaries();
+ if (partialKeyStatisticsInformation.getTimeSegments().contains(null)) {
+ // Time should not contain null value
+ failForReason(InsertTimeNullFault.instance());
+ return getPhase();
+ }
+
+ completeKeyStatisticsInformation.mergePartialInformation(workerNumber,
partialKeyStatisticsInformation);
+
+ if (workersWithReportedKeyStatistics.size() == workerCount) {
+ // All workers have sent the report.
+ // Transition to MERGING_STATISTICS state to queue fetch clustering
statistics from workers.
+ transitionTo(ControllerStagePhase.MERGING_STATISTICS);
Review Comment:
Added comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
