cryptoe commented on code in PR #13366:
URL: https://github.com/apache/druid/pull/13366#discussion_r1033152602
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/scan/ScanQueryFrameProcessor.java:
##########
@@ -228,7 +229,14 @@ private void populateFrameWriterAndFlushIfNeeded() throws
IOException
createFrameWriterIfNeeded();
while (!cursor.isDone()) {
- if (!frameWriter.addSelection()) {
+ boolean addedSelection;
Review Comment:
We should also make this change in all the leaf processors.
So it can be the scan processor and the `GroupByPreShuffleFrameProcessor`.
So this change might be required there as well.
Or you can send the common code to the superclass `BaseLeafFrameProcessor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
