LakshSingla commented on code in PR #13366:
URL: https://github.com/apache/druid/pull/13366#discussion_r1034323954
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/scan/ScanQueryFrameProcessor.java:
##########
@@ -228,7 +229,14 @@ private void populateFrameWriterAndFlushIfNeeded() throws
IOException
createFrameWriterIfNeeded();
while (!cursor.isDone()) {
- if (!frameWriter.addSelection()) {
+ boolean addedSelection;
Review Comment:
Updated the test case and made the change. Instead of the individual
processors, I have added the handling in the individual frame writers so that
we won't have to add a block in every processor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
