cryptoe commented on code in PR #13433:
URL: https://github.com/apache/druid/pull/13433#discussion_r1033436171
##########
integration-tests-ex/cases/src/test/java/org/apache/druid/testsEx/msq/AbstractITSQLBasedIngestion.java:
##########
@@ -46,6 +52,28 @@
@Inject
private DataLoaderHelper dataLoaderHelper;
+ @Rule
+ public TestWatcher watchman = new TestWatcher()
+ {
+ @Override
+ public void starting(Description d)
+ {
+ LOG.info("\n\n\nRunning %s", d.getDisplayName());
+ }
+
+ @Override
+ public void failed(Throwable e, Description d)
+ {
+ LOG.error("%s FAILED\n", d.getDisplayName());
+ }
+
+ @Override
+ public void finished(Description d)
+ {
+ LOG.info("%s finished\n", d.getDisplayName());
Review Comment:
```suggestion
LOG.info("FINISHED %s", d.getDisplayName());
```
minor nit.
##########
integration-tests-ex/cases/src/test/java/org/apache/druid/testsEx/msq/AbstractITSQLBasedIngestion.java:
##########
@@ -46,6 +52,28 @@
@Inject
private DataLoaderHelper dataLoaderHelper;
+ @Rule
+ public TestWatcher watchman = new TestWatcher()
+ {
+ @Override
+ public void starting(Description d)
+ {
+ LOG.info("\n\n\nRunning %s", d.getDisplayName());
Review Comment:
```suggestion
LOG.info("RUNNING %s", d.getDisplayName());
```
##########
integration-tests-ex/cases/src/test/java/org/apache/druid/testsEx/msq/AbstractITSQLBasedIngestion.java:
##########
@@ -46,6 +52,28 @@
@Inject
private DataLoaderHelper dataLoaderHelper;
+ @Rule
+ public TestWatcher watchman = new TestWatcher()
+ {
+ @Override
+ public void starting(Description d)
+ {
+ LOG.info("\n\n\nRunning %s", d.getDisplayName());
+ }
+
+ @Override
+ public void failed(Throwable e, Description d)
+ {
+ LOG.error("%s FAILED\n", d.getDisplayName());
Review Comment:
```suggestion
LOG.error("FAILED %s", d.getDisplayName());
```
##########
integration-tests/src/main/java/org/apache/druid/testing/utils/SqlTestQueryHelper.java:
##########
@@ -59,6 +59,7 @@ public boolean isDatasourceLoadedInSQL(String datasource)
null
);
+ LOG.info("Verifying datasource [%s] availability for SQL queries",
datasource);
Review Comment:
I think this log line is not needed as we already have one in
DataLoadHelper#48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
