cryptoe commented on code in PR #13353:
URL: https://github.com/apache/druid/pull/13353#discussion_r1033634271
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -564,6 +585,34 @@ private QueryDefinition initializeQueryDefAndState(final
Closer closer)
return queryDef;
}
+ /**
+ * Adds the workorders for worker to {@link
ControllerImpl#workOrdersToRetry} if the {@link ControllerQueryKernel}
determines that there
+ * are work orders which needs reprocessing.
+ */
+ private void addToRetryQueue(ControllerQueryKernel kernel, int worker,
MSQFault fault)
+ {
+ List<WorkOrder> retriableWorkOrders =
kernel.getWorkInCaseWorkerElgibileForRetryElseThrow(worker, fault);
+ if (retriableWorkOrders.size() != 0) {
+ log.info("Submitting worker[%s] for relaunch because of fault[%s]",
worker, fault);
Review Comment:
That information is inside the MSQWorkerTaskLauncher.
We donot have it here. What we do have is worker which is part of the log
already.
What I have done is added the relaunch counter to the log message inside the
MSQWorkerTaskLauncher#relaunchTasks
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -564,6 +585,34 @@ private QueryDefinition initializeQueryDefAndState(final
Closer closer)
return queryDef;
}
+ /**
+ * Adds the workorders for worker to {@link
ControllerImpl#workOrdersToRetry} if the {@link ControllerQueryKernel}
determines that there
+ * are work orders which needs reprocessing.
+ */
+ private void addToRetryQueue(ControllerQueryKernel kernel, int worker,
MSQFault fault)
+ {
+ List<WorkOrder> retriableWorkOrders =
kernel.getWorkInCaseWorkerElgibileForRetryElseThrow(worker, fault);
+ if (retriableWorkOrders.size() != 0) {
+ log.info("Submitting worker[%s] for relaunch because of fault[%s]",
worker, fault);
Review Comment:
That information is inside the MSQWorkerTaskLauncher.
We do not have it here. What we do have is worker which is part of the log
already.
What I have done is added the relaunch counter to the log message inside the
MSQWorkerTaskLauncher#relaunchTasks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
