techdocsmith commented on code in PR #13436:
URL: https://github.com/apache/druid/pull/13436#discussion_r1033863415
##########
docs/multi-stage-query/api.md:
##########
@@ -102,7 +102,7 @@ headers = {
'Content-Type': 'application/json'
}
-response = requests.request("POST", url, headers=headers, data=payload)
+response = requests.post(url, headers=headers, data=payload, auth=(<username>,
<password>))
Review Comment:
can we use python variables instead of bracketed variables to indicate
username/password?
```suggestion
username = HTTP_AUTH_USER
password = HTTP_AUTH_PASSWORD
response = requests.post(url, headers=headers, data=payload, auth=(username,
password))
```
##########
docs/multi-stage-query/api.md:
##########
@@ -144,7 +144,7 @@ GET /druid/indexer/v1/task/<taskId>
```bash
# Make sure you replace `username`, `password`, `your-instance`, `port`, and
`taskId` with the values for your deployment.
-curl --location --request GET
'https://<username>:<password>@<hostname>:<port>/druid/indexer/v1/task/<taskId>/status'
+curl --location --request GET
'https://<username>:<password>@<your-instance>:<port>/druid/indexer/v1/task/<taskId>/status'
Review Comment:
can we please change this to pass credentials in the header rather than as
part of the URL. See: https://github.com/apache/druid/issues/13193. Looks like
this was done in line 105.
For curl it would use this syntax:
`curl --user username:password GET
'https://<your-instance>:<port>/druid/indexer/v1/task/<taskId>/status'`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
