adarshsanjeev commented on code in PR #13463:
URL: https://github.com/apache/druid/pull/13463#discussion_r1035959363
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/WorkerChatHandler.java:
##########
@@ -193,10 +194,17 @@ public Response httpFetchKeyStatistics(
ChatHandlers.authorizationCheck(req, Action.READ, task.getDataSource(),
toolbox.getAuthorizerMapper());
ClusterByStatisticsSnapshot clusterByStatisticsSnapshot;
StageId stageId = new StageId(queryId, stageNumber);
- clusterByStatisticsSnapshot = worker.fetchStatisticsSnapshot(stageId);
- return Response.status(Response.Status.ACCEPTED)
- .entity(clusterByStatisticsSnapshot)
- .build();
+ try {
+ clusterByStatisticsSnapshot = worker.fetchStatisticsSnapshot(stageId);
+ return Response.status(Response.Status.ACCEPTED)
+ .entity(clusterByStatisticsSnapshot)
+ .build();
+ }
+ catch (ISE e) {
+ log.error(e, "Invalid request for key statistics");
Review Comment:
We can do that, I wasn't sure if this needed to be returned to the caller or
just logged. I would also assume that we should call ISE.sanitize() before we
do so, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
