cryptoe commented on code in PR #13463:
URL: https://github.com/apache/druid/pull/13463#discussion_r1047415353
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -615,7 +615,9 @@ public void updatePartialKeyStatisticsInformation(int
stageNumber, int workerNum
queryKernel.addPartialKeyStatisticsForStageAndWorker(stageId,
workerNumber, partialKeyStatisticsInformation);
if
(queryKernel.getStagePhase(stageId).equals(ControllerStagePhase.MERGING_STATISTICS))
{
- List<String> workerTaskIds = workerTaskLauncher.getTaskList();
+ // we only need tasks which are active for this stage.
+ List<String> workerTaskIds = workerTaskLauncher.getTaskList()
Review Comment:
Yes, we can be sure that getTaskList() is active tasks only.
It's kind of a coincidence that the moment you commented, I changed this
logic to a less brittle one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
