clintropolis opened a new pull request, #13499:
URL: https://github.com/apache/druid/pull/13499
Fixes #10600.
### Description
This PR fixes an issue when `druid.serverview.type=http` is set, the
mechanics of which use “long polling” to keep track of which servers have which
segments, which interferes with the data node “graceful” shutdown of the Jetty
server (the period is controlled by
`druid.server.http.gracefulShutdownTimeout`). The default timeout for the long
polling requests is 4 minutes, which is much longer than the 30s default
request timeout, so the requests never finish, the jetty server blocks for the
entire `gracefulShutdownTimeout`, and leaves an ugly error about
`TimeoutException` for the request that was not completed within the timeout.
This happens consistently with both realtime streaming tasks and historical
servers.
The solution is to make `ChangeRequestHistory` which is the historical side
mechanism that serves the segment changes to brokers and coordinators be tied
into the ‘announcement’ phase of the lifecycle, so that the futures can be
resolved and the executor shutdown before we begin shutting down jetty, which
will ensure that these requests do not tie up the jetty threads for something
that isn’t going to happen.
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
