rohangarg commented on code in PR #13420:
URL: https://github.com/apache/druid/pull/13420#discussion_r1041437875
##########
processing/src/main/java/org/apache/druid/query/QueryMetrics.java:
##########
@@ -396,6 +396,30 @@
*/
QueryMetrics<QueryType> reportParallelMergeTotalCpuTime(long timeNs);
+ /**
+ * Reports broker total "wall" time in nanoseconds from parallel merge start
sequence creation to total
+ * consumption.
+ */
+ QueryMetrics<QueryType> reportParallelMergeTotalTime(long timeNs);
+
+ /**
+ * Reports broker "wall" time in nanoseconds for the fastest parallel merge
sequence partition to be 'initialized',
+ * where 'initialized' is time to the first result batch is populated from
data servers and merging can begin.
+ *
+ * Similar to query 'time to first byte' metrics, except is a composite of
the whole group of data servers which are
+ * present in the merge partition, which all must supply an initial result
batch before merging can actually begin.
+ */
+ QueryMetrics<QueryType> reportParallelMergeFastestPartitionTime(long timeNs);
Review Comment:
yes, agree that these metrics should correlate to TTFBs - skewness from them
would be useful to find anomalies in data distribution, historical slowness or
the pool being overloaded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
