clintropolis commented on PR #13420: URL: https://github.com/apache/druid/pull/13420#issuecomment-1339981681
I'm not sure it makes sense to add tests to make the coverage bot happy since these metrics are not emitted by default and tests seem pointless. Specifically, its complaining about these two files: ``` Diff coverage statistics: ------------------------------------------------------------------------------ | lines | branches | functions | path ------------------------------------------------------------------------------ | 0% (0/3) | 100% (0/0) | 44% (4/9) | org/apache/druid/query/DefaultQueryMetrics.java | 0% (0/3) | 100% (0/0) | 50% (2/4) | org/apache/druid/query/search/DefaultSearchQueryMetrics.java ------------------------------------------------------------------------------ ``` the first of which just has no-ops which do nothing, and the latter just delegate to the underlying metrics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
