imply-cheddar opened a new pull request, #13514:
URL: https://github.com/apache/druid/pull/13514
This adds support for framing over ROWS for window aggregations.
Still not implemented as yet:
1. RANGE frames
2. Multiple different frames in the same query
3. Frames on last/first functions
This PR also brings with it some adjustments and improvements to the tests
for semantic interfaces and RowsAndColumns implementations.
The PR touches a lot of files, that's mostly because I combined all of the
"semantic interfaces" into a `semantic` package and that affected a bunch of
imports.
The PR also looks like it's a lot of lines of code, but most of that is
actually whitespace changes on some of the test files done by auto-formatting.
Checking them in now so that future auto-formatting is safe from generating
whitespace changes.
The primary code to review is essentially all inside of
FramedOnHeapAggregatable, the tests associated with it and some in the planning.
Lastly, there are some code cleanup/renames being included that were asked
for in the previous PR. (Things like completing the renaming of `cell` and
removing the TODOs)
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
