gianm commented on code in PR #13506:
URL: https://github.com/apache/druid/pull/13506#discussion_r1042613906
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -595,8 +596,8 @@ public void updatePartialKeyStatisticsInformation(int
stageNumber, int workerNum
final StageDefinition stageDef =
queryKernel.getStageDefinition(stageId);
final ObjectMapper mapper =
MSQTasks.decorateObjectMapperForKeyCollectorSnapshot(
context.jsonMapper(),
- stageDef.getShuffleSpec().get().getClusterBy(),
- stageDef.getShuffleSpec().get().doesAggregateByClusterKey()
+ stageDef.getShuffleSpec().clusterBy(),
+ stageDef.getShuffleSpec().doesAggregate()
Review Comment:
I don't love them for holder objects that don't "do" anything. Just personal
preference I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
