gianm commented on PR #13506: URL: https://github.com/apache/druid/pull/13506#issuecomment-1341517191
> Only just a few nit-level comments so far. I haven't gotten too far, but wanted to leave them as I will need to wander off and come back to this. The last thing I did was read through WorkerImpl, as a newbie to this side of the code, I didn't know if I should expect it to just be a whole bunch of wiring up of objects or if there should be actual logic to it. From what I saw, it seemed like it's all doing just wiring up of things. If that's expected, great. If there was supposed to be business logic inside of it that is essential for the sortMerge algorithm, it got lost on me in the overall scope of what WorkerImpl is doing. Thanks for taking a look! WorkerImpl is indeed meant to just write things up and them let them rip. The join algorithm is entirely contained within SortMergeJoinFrameProcessor. The rest of the changes (the majority of the changes) are about adding hash-based shuffles to MSQ, which previously only included range-based shuffles. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
