paul-rogers commented on PR #13360: URL: https://github.com/apache/druid/pull/13360#issuecomment-1343638827
@gian, thanks for the comments! A few answers: 1. Yes, it is possible to use the syntax with `extern`. I've not wired that up, but doing so should be straightforward. 2. It is on the to-do list to use an array type for list arguments. Might be in the next PR. 3. So, on the docs, my intent was to refer to the existing docs rather than repeating stuff. I'll change it to use whatever names we use for those things elsewhere. 4. The argument names are deliberately shorter than the JSON field names. Folks will be typing this, the name space is small, so no need for the verbose names we use in JSON. The JSON names were not selected with typing usability in mind. `httpAuthenticationUsername` Really? 5. Thanks for the note on JSON. Is the `keepNullColumns` meant to be supported? If so, we can clean up the JSON input format docs, and I'll reference that here. If it is _not_ supported, I'll remove the function arg. (There are some new JSON format args that I've not yet added for nested types.) 6. I guess I disagree with the analysis that the functionality is not broken. If I set my `baseDir` to "/tmp", and my files to "x.csv", I expect Druid to read "/tmp/x.csv" not "/Users/paul/druid/x.csv". Not all local input files are relative to Druid's product directly. That said, thanks for fixing the issue. I'll rerun the tests with your fix and correct the wording. Thanks for adding the release notes label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
