paul-rogers commented on PR #13360: URL: https://github.com/apache/druid/pull/13360#issuecomment-1344869197
@gianm, to fix 4, how far do we want to go? I'm using they argument name "format" for the format. Should we change that to "inputFormat" to be consistent with existing code? Maybe not, since this particular field is not visible, except as an argument name to `extern`, where it has a different meaning? I'll change all the other parameters to the JSON forms. We can see if we get user feedback about name lengths, and can add new names later if so. Else, we just add to the confusion because we have to document back in the native ingest pages that fields that used to be called "veryLongOldName" are now just called "name". Consistency seems more important than brevity. For the HTTP input source, the JSON uses `httpAuthenticationPassword` for both the plain text and env var. In SQL, these have to be different. So, to keep the existing names, we use `httpAuthenticationPassword` for the plain text password and `httpAuthenticationPasswordEnvVar` for the `"type": "environment"` version. I hope users appreciate these long names... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
