gianm commented on code in PR #13394:
URL: https://github.com/apache/druid/pull/13394#discussion_r1044865405
##########
server/src/main/java/org/apache/druid/segment/loading/LocalDataSegmentPusher.java:
##########
@@ -106,27 +130,61 @@ public DataSegment pushToPath(File dataSegmentFile,
DataSegment segment, String
throw new IOE("Failed to rename [%s] to [%s]", tmpIndexFile,
indexFileTarget);
}
- return dataSegment;
+ return baseSegment.withLoadSpec(makeLoadSpec(new File(outDir,
INDEX_ZIP_FILENAME).toURI()))
+ .withSize(size);
}
finally {
- FileUtils.deleteDirectory(tmpOutDir);
+ FileUtils.deleteDirectory(tmpSegmentDir);
}
}
- @Override
- public Map<String, Object> makeLoadSpec(URI finalIndexZipFilePath)
+ private DataSegment pushNoZip(final File inDir, final File outDir, final
DataSegment baseSegment) throws IOException
Review Comment:
Yep, that is exactly how hard links work. Each one is just as good as all
the other ones, none is more "real" than the other once multiple are created.
##########
server/src/main/java/org/apache/druid/segment/loading/LocalDataSegmentPusher.java:
##########
@@ -106,27 +130,61 @@ public DataSegment pushToPath(File dataSegmentFile,
DataSegment segment, String
throw new IOE("Failed to rename [%s] to [%s]", tmpIndexFile,
indexFileTarget);
}
- return dataSegment;
+ return baseSegment.withLoadSpec(makeLoadSpec(new File(outDir,
INDEX_ZIP_FILENAME).toURI()))
+ .withSize(size);
}
finally {
- FileUtils.deleteDirectory(tmpOutDir);
+ FileUtils.deleteDirectory(tmpSegmentDir);
}
}
- @Override
- public Map<String, Object> makeLoadSpec(URI finalIndexZipFilePath)
+ private DataSegment pushNoZip(final File inDir, final File outDir, final
DataSegment baseSegment) throws IOException
Review Comment:
Yep, that is exactly how hard links work. Each one is just as good as all
the other ones, none is more "real" than the others once multiple are created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
