gianm commented on code in PR #13394:
URL: https://github.com/apache/druid/pull/13394#discussion_r1044882964


##########
docs/dependencies/deep-storage.md:
##########
@@ -25,24 +25,47 @@ title: "Deep storage"
 
 Deep storage is where segments are stored.  It is a storage mechanism that 
Apache Druid does not provide.  This deep storage infrastructure defines the 
level of durability of your data, as long as Druid processes can see this 
storage infrastructure and get at the segments stored on it, you will not lose 
data no matter how many Druid nodes you lose.  If segments disappear from this 
storage layer, then you will lose whatever data those segments represented.
 
-## Local Mount
+## Local
 
-A local mount can be used for storage of segments as well.  This allows you to 
use just your local file system or anything else that can be mount locally like 
NFS, Ceph, etc.  This is the default deep storage implementation.
+Local storage is intended for use in the following situations:
 
-In order to use a local mount for deep storage, you need to set the following 
configuration in your common configs.
+- You have just one server.
+- Or, you have multiple servers, and they all have access to a shared 
filesystem (for example: NFS).
+
+In order to use a local directory for deep storage, set the following 
configuration in `common.runtime.properties`.
 
 |Property|Possible Values|Description|Default|
 |--------|---------------|-----------|-------|
-|`druid.storage.type`|local||Must be set.|
-|`druid.storage.storageDirectory`||Directory for storing segments.|Must be 
set.|
+|`druid.storage.type`|`local`||Must be set.|
+|`druid.storage.storageDirectory`|any local directory|Directory for storing 
segments. Must be different from `druid.segmentCache.locations` and 
`druid.segmentCache.infoDir`.|`/tmp/druid/localStorage`|
+|`druid.storage.zip`|`true`, `false`|Whether segments in 
`druid.storage.storageDirectory` are written as directories (`false`) or zip 
files (`true`).|`false`|
+
+For example:
+
+```
+druid.storage.type=local
+druid.storage.storageDirectory=/tmp/druid/localStorage
+```
+
+When using local storage, it is recommended to use the same filesystem for 
`druid.storage.type` and
+`druid.segmentCache.locations` on your Historicals. When these are on the same 
filesystem, and
+`druid.storage.zip = false` (the default), Druid creates hard links between 
the two directories rather than storing
+two copies of the same data.

Review Comment:
   It was weirdly tough to edit the docs in a way that felt right. I ended up 
moving the "you should use cloud storage in prod" to the top, and deleting the 
bottom section about hard links. It started to get tough to talk about it while 
maintaining the appropriate level of "don't actually do this in prod". I don't 
think that section of the doc added much, so I felt OK removing it.



##########
docs/dependencies/deep-storage.md:
##########
@@ -25,24 +25,47 @@ title: "Deep storage"
 
 Deep storage is where segments are stored.  It is a storage mechanism that 
Apache Druid does not provide.  This deep storage infrastructure defines the 
level of durability of your data, as long as Druid processes can see this 
storage infrastructure and get at the segments stored on it, you will not lose 
data no matter how many Druid nodes you lose.  If segments disappear from this 
storage layer, then you will lose whatever data those segments represented.
 
-## Local Mount
+## Local
 
-A local mount can be used for storage of segments as well.  This allows you to 
use just your local file system or anything else that can be mount locally like 
NFS, Ceph, etc.  This is the default deep storage implementation.
+Local storage is intended for use in the following situations:
 
-In order to use a local mount for deep storage, you need to set the following 
configuration in your common configs.
+- You have just one server.
+- Or, you have multiple servers, and they all have access to a shared 
filesystem (for example: NFS).
+
+In order to use a local directory for deep storage, set the following 
configuration in `common.runtime.properties`.
 
 |Property|Possible Values|Description|Default|
 |--------|---------------|-----------|-------|
-|`druid.storage.type`|local||Must be set.|
-|`druid.storage.storageDirectory`||Directory for storing segments.|Must be 
set.|
+|`druid.storage.type`|`local`||Must be set.|
+|`druid.storage.storageDirectory`|any local directory|Directory for storing 
segments. Must be different from `druid.segmentCache.locations` and 
`druid.segmentCache.infoDir`.|`/tmp/druid/localStorage`|
+|`druid.storage.zip`|`true`, `false`|Whether segments in 
`druid.storage.storageDirectory` are written as directories (`false`) or zip 
files (`true`).|`false`|
+
+For example:
+
+```
+druid.storage.type=local
+druid.storage.storageDirectory=/tmp/druid/localStorage
+```
+
+When using local storage, it is recommended to use the same filesystem for 
`druid.storage.type` and
+`druid.segmentCache.locations` on your Historicals. When these are on the same 
filesystem, and
+`druid.storage.zip = false` (the default), Druid creates hard links between 
the two directories rather than storing
+two copies of the same data.
+
+Local storage cannot be used if you have multiple servers without a shared 
filesystem. In this case, consider using

Review Comment:
   After reflection, I ended up removing this section.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to