jon-wei commented on code in PR #13513:
URL: https://github.com/apache/druid/pull/13513#discussion_r1046311713
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java:
##########
@@ -546,6 +553,41 @@ public TaskStatus runTask(final TaskToolbox toolbox)
}
}
+ private void emitUnparseableEvents(TaskToolbox toolbox)
+ {
+ String taskId = getId();
+ for(Map.Entry<String, Object> unparseableEvents :
getTaskCompletionUnparseableEvents().entrySet()) {
Review Comment:
```
private Map<String, Object> getTaskCompletionUnparseableEvents()
{
Map<String, Object> unparseableEventsMap = new HashMap<>();
CircularBuffer<ParseExceptionReport>
determinePartitionsParseExceptionReports =
determinePartitionsParseExceptionHandler.getSavedParseExceptionReports();
CircularBuffer<ParseExceptionReport> buildSegmentsParseExceptionReports =
buildSegmentsParseExceptionHandler.getSavedParseExceptionReports();
if (determinePartitionsParseExceptionReports != null ||
buildSegmentsParseExceptionReports != null) {
unparseableEventsMap.put(
RowIngestionMeters.DETERMINE_PARTITIONS,
IndexTaskUtils.getReportListFromSavedParseExceptions(determinePartitionsParseExceptionReports)
);
unparseableEventsMap.put(
RowIngestionMeters.BUILD_SEGMENTS,
IndexTaskUtils.getReportListFromSavedParseExceptions(buildSegmentsParseExceptionReports)
);
}
return unparseableEventsMap;
}
```
This could result in redundant parse exceptions, the map has a entry for
`DETERMINE_PARTITIONS` and another for `BUILD_SEGMENTS`, we may want to just
pick one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
