somu-imply commented on code in PR #13513:
URL: https://github.com/apache/druid/pull/13513#discussion_r1042653564


##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java:
##########
@@ -546,6 +553,41 @@ public TaskStatus runTask(final TaskToolbox toolbox)
     }
   }
 
+  private void emitUnparseableEvents(TaskToolbox toolbox)
+  {
+    String taskId = getId();

Review Comment:
   There are inherent similarities between these two methods here and in 
ParallelIndexSupervisorTask. Would be good if we could move the commonalities 
to an utils or a common class



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to