kfaraz commented on code in PR #13564:
URL: https://github.com/apache/druid/pull/13564#discussion_r1049221772
##########
server/src/main/java/org/apache/druid/server/QueryResource.java:
##########
@@ -565,4 +496,142 @@ public static void transferEntityTag(ResponseContext
context, Response.ResponseB
builder.header(HEADER_ETAG, entityTag);
}
}
+
+ private class QueryResourceQueryMetricCounter implements QueryMetricCounter
+ {
+ @Override
+ public void incrementSuccess()
+ {
+ successfulQueryCount.incrementAndGet();
Review Comment:
I meant move the fields to `QueryResourceQueryMetricCounter` as they are
only ever incremented through the methods here and can also have `getters`
here.
But it was just a stye nitpick, it's perfectly fine either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
