rohangarg commented on code in PR #13476:
URL: https://github.com/apache/druid/pull/13476#discussion_r1049441918


##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/BaseRestorableTaskRunner.java:
##########
@@ -74,38 +76,42 @@ public BaseRestorableTaskRunner(
   @Override
   public List<Pair<Task, ListenableFuture<TaskStatus>>> restore()
   {
-    final File restoreFile = getRestoreFile();
-    final TaskRestoreInfo taskRestoreInfo;
-    if (restoreFile.exists()) {
-      try {
-        taskRestoreInfo = jsonMapper.readValue(restoreFile, 
TaskRestoreInfo.class);
-      }
-      catch (Exception e) {
-        LOG.error(e, "Failed to read restorable tasks from file[%s]. Skipping 
restore.", restoreFile);
-        return ImmutableList.of();
+    final Map<File, TaskRestoreInfo> taskRestoreInfos = new HashMap<>();
+    for (File baseDir : taskConfig.getBaseTaskDirs()) {
+      File restoreFile = new File(baseDir, TASK_RESTORE_FILENAME);
+      if (restoreFile.exists()) {

Review Comment:
   I'm not sure if this is done - can you please verify?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to