AmatyaAvadhanula commented on code in PR #13476:
URL: https://github.com/apache/druid/pull/13476#discussion_r1049508712


##########
indexing-service/src/main/java/org/apache/druid/indexing/common/config/TaskConfig.java:
##########
@@ -182,6 +197,16 @@ public TaskConfig(
     }
     log.debug("Batch processing mode:[%s]", this.batchProcessingMode);
     this.storeEmptyColumns = storeEmptyColumns == null ? 
DEFAULT_STORE_EMPTY_COLUMNS : storeEmptyColumns;
+
+    this.baseTaskDir = baseTaskDir;
+    if (CollectionUtils.isNullOrEmpty(baseTaskDirPaths)) {

Review Comment:
   Certain deployments have default configurations which are already set. If 
baseTaskDir is one of them, it would benefit them if the property could be 
overridden with baseTaskDirPaths without throwing an exception



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to