kfaraz commented on code in PR #13558:
URL: https://github.com/apache/druid/pull/13558#discussion_r1052890665
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/TaskQueueTest.java:
##########
@@ -350,6 +378,154 @@ public boolean isReady(TaskActionClient taskActionClient)
);
}
+ @Test
+ public void testHttpRemoteTaskRunnerTaskShutdownMetricsEmission() throws
EntryExistsException, InterruptedException
Review Comment:
Shouldn't this test be a part of `HttpRemoteTaskRunner` itself?
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/TaskQueueTest.java:
##########
@@ -350,6 +378,154 @@ public boolean isReady(TaskActionClient taskActionClient)
);
}
+ @Test
+ public void testHttpRemoteTaskRunnerTaskShutdownMetricsEmission() throws
EntryExistsException, InterruptedException
Review Comment:
Shouldn't this test be a part of `HttpRemoteTaskRunnerTest`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
