kfaraz commented on code in PR #13558:
URL: https://github.com/apache/druid/pull/13558#discussion_r1052892199
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/hrtr/HttpRemoteTaskRunnerTest.java:
##########
@@ -1606,7 +1607,68 @@ WorkerNodeService.DISCOVERY_SERVICE_KEY, new
WorkerNodeService("ip1", 2, "0", Wo
);
}
- private HttpRemoteTaskRunner createTaskRunnerForTestTaskAddedOrUpdated(
+ /**
+ * Validate the internal state of tasks withing the task runner
Review Comment:
Thanks for adding the comments! But this seems either a little broad for a
test. If you are validating multiple, consider breaking up the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]