imply-cheddar opened a new pull request, #13619: URL: https://github.com/apache/druid/pull/13619
Adds the `NaiveSortMaker` and `NaiveSortOperator` which handle sorting. This adds a default implementation of the sort operation as well. Additionally, `SortedGroupPartitioner` has been renamed to `ClusteredGroupPartitioner` as the semantics actually don't require sorting (which requires definition of a direction). This PR has: - [x] been self-reviewed. - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
