imply-cheddar commented on code in PR #13619: URL: https://github.com/apache/druid/pull/13619#discussion_r1063225811
########## processing/src/main/java/org/apache/druid/query/operator/ColumnWithDirection.java: ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.query.operator; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonProperty; + +import java.util.Objects; + +public class ColumnWithDirection Review Comment: Yeah, I started using `OrderByColumnSpec`, it had a comparator on it that I was ignoring and it didn't have a good way to get at the comparator with the direction for me, so I gave up on it. I wasn't aware of `ScanQuery.OrderBy`, that one looks closer to what I need and could maybe be adjusted to have the comparator multiplier on it. I'm not quite sure what `NONE` means for an ordering though... I agree that we should not have so many, can probably look to converge what I have here with `ScanQuery.OrderBy`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
