github-code-scanning[bot] commented on code in PR #13576:
URL: https://github.com/apache/druid/pull/13576#discussion_r1069791823
##########
processing/src/test/java/org/apache/druid/segment/UnnestColumnValueSelectorCursorTest.java:
##########
@@ -579,7 +578,7 @@
Collections.singletonList("j")
);
- List<String> expectedResults = Arrays.asList("a", "b", "c", "e", "f", "g",
"h", "i", "j");
+ List<String> expectedResults = Arrays.asList("a", "b", "c", "e", "f", "g",
"h", "i", null);
Review Comment:
## Unread local variable
Variable 'List<String> expectedResults' is never read.
[Show more
details](https://github.com/apache/druid/security/code-scanning/3664)
##########
processing/src/test/java/org/apache/druid/segment/UnnestColumnValueSelectorCursorTest.java:
##########
@@ -592,7 +591,17 @@
OUTPUT_NAME,
IGNORE_SET
);
-
unnestCursor.getColumnSelectorFactory().makeDimensionSelector(DefaultDimensionSpec.of(OUTPUT_NAME));
+ // should return a column value selector for this case
+ ColumnValueSelector<?> unnestColumnValueSelector =
unnestCursor.getColumnSelectorFactory().makeDimensionSelector(DefaultDimensionSpec.of(OUTPUT_NAME));
+ int k = 0;
+ while (!unnestCursor.isDone()) {
+ Object valueSelectorVal = unnestColumnValueSelector.getObject();
Review Comment:
## Unread local variable
Variable 'Object valueSelectorVal' is never read.
[Show more
details](https://github.com/apache/druid/security/code-scanning/3665)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
