somu-imply commented on code in PR #13576:
URL: https://github.com/apache/druid/pull/13576#discussion_r1081615896
##########
processing/src/test/java/org/apache/druid/segment/UnnestColumnValueSelectorCursorTest.java:
##########
@@ -592,7 +590,25 @@ public void test_list_unnest_cursors_dimSelector()
OUTPUT_NAME,
IGNORE_SET
);
-
unnestCursor.getColumnSelectorFactory().makeDimensionSelector(DefaultDimensionSpec.of(OUTPUT_NAME));
+ // should return a column value selector for this case
+ BaseSingleValueDimensionSelector unnestDimSelector =
(BaseSingleValueDimensionSelector) unnestCursor.getColumnSelectorFactory()
+
.makeDimensionSelector(
+
DefaultDimensionSpec.of(
+
OUTPUT_NAME));
+ unnestDimSelector.inspectRuntimeShape(null);
+ int k = 0;
+ while (!unnestCursor.isDone()) {
+ if (k < 8) {
+ Assert.assertEquals(unnestDimSelector.getValue(),
expectedResults.get(k).toString());
Review Comment:
Thanks, actually in this file all were inverted. Good catch ! I'll update
all of them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
