findingrish commented on code in PR #13682:
URL: https://github.com/apache/druid/pull/13682#discussion_r1073825727
##########
core/src/main/java/org/apache/druid/math/expr/Function.java:
##########
@@ -3681,4 +3681,58 @@ protected HumanReadableBytes.UnitSystem getUnitSystem()
return HumanReadableBytes.UnitSystem.DECIMAL;
}
}
+
+
+ class DateExpandFunction implements Function
+ {
+ @Override
+ public String name()
+ {
+ return "date_expand";
+ }
+
+ @Override
+ public void validateArguments(List<Expr> args)
+ {
+ validationHelperCheckArgumentCount(args, 3);
Review Comment:
Sure, I will add javadocs.
> There was also a plan to introduce granularity like hr,min or sec, are we
doing it ?
For now, we will go ahead with this signature in Imply. Once the method
signature is stable will add the changes here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
