github-code-scanning[bot] commented on code in PR #13714:
URL: https://github.com/apache/druid/pull/13714#discussion_r1088959516
##########
processing/src/test/java/org/apache/druid/query/NestedDataTestUtils.java:
##########
@@ -223,6 +231,95 @@
return segments;
}
+ public static List<Segment> createSegmentsWithConcatenatedInput(
+ AggregationTestHelper helper,
+ TemporaryFolder tempFolder,
+ Closer closer,
+ Granularity granularity,
+ boolean rollup,
+ int maxRowCount,
+ int numCopies,
+ int numSegments
+ ) throws Exception
+ {
+ return createSegmentsWithConcatenatedInput(
+ helper,
+ tempFolder,
+ closer,
+ SIMPLE_DATA_FILE,
+ SIMPLE_PARSER_FILE,
+ null,
+ SIMPLE_AGG_FILE,
+ granularity,
+ rollup,
+ maxRowCount,
+ numCopies,
+ numSegments
+ );
+ }
+
+ /**
+ * turn small test data into bigger test data by duplicating itself into a
bigger stream
+ */
+ public static List<Segment> createSegmentsWithConcatenatedInput(
+ AggregationTestHelper helper,
+ TemporaryFolder tempFolder,
+ Closer closer,
+ String inputFileName,
+ String parserJsonFileName,
+ String transformSpecJsonFileName,
+ String aggJsonFileName,
+ Granularity granularity,
+ boolean rollup,
+ int maxRowCount,
+ int numCopies,
+ int numSegments
+ ) throws Exception
+ {
+ String parserJson = readFileFromClasspathAsString(parserJsonFileName);
+ String transformSpecJson = transformSpecJsonFileName != null ?
readFileFromClasspathAsString(transformSpecJsonFileName) : null;
+ String aggJson = readFileFromClasspathAsString(aggJsonFileName);
+
+ List<File> segmentDirs = Lists.newArrayListWithCapacity(numSegments);
+ for (int i = 0; i < numSegments; i++) {
+ List<InputStream> inputStreams =
Lists.newArrayListWithCapacity(numCopies);
+ for (int j = 0; j < numCopies; j++) {
+ inputStreams.add(new
FileInputStream(readFileFromClasspath(inputFileName)));
Review Comment:
## Potential input resource leak
This FileInputStream is not always closed on method exit.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4202)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
