imply-cheddar commented on code in PR #13714:
URL: https://github.com/apache/druid/pull/13714#discussion_r1092759252
##########
processing/src/main/java/org/apache/druid/segment/nested/GlobalDictionaryEncodedFieldColumnWriter.java:
##########
@@ -133,8 +134,15 @@ public void addValue(int row, Object val) throws
IOException
fillNull(row);
}
final T value = processValue(val);
- final int globalId = lookupGlobalId(value);
- final int localId = localDictionary.add(globalId);
+ final int localId;
+ // null is always 0
+ if (value == null) {
+ localId = localDictionary.add(0);
+ } else {
+ final int globalId = lookupGlobalId(value);
+ Preconditions.checkArgument(globalId >= 0, "Value [%s] is not present in
global dictionary", value);
+ localId = localDictionary.add(globalId);
+ }
Review Comment:
Why is it not okay to do this check inside of `lookupGlobalId`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
