clintropolis opened a new pull request, #13732:
URL: https://github.com/apache/druid/pull/13732
### Description
This PR fixes a handful of semi-related issues, mostly to do with with
nested columns, and some of them a result (or easier to encounter) after the
introduction of the type 'mimic' behavior introduced in #13653.
changes:
* modified druid schema column type compution to special case COMPLEX<json>
handling to choose COMPLEX<json> if any column in any segment is COMPLEX<json>
* NestedFieldVirtualColumn can now work correctly on any type of column,
returning either a column selector if a root path, or nil selector if not
* fixed a random bug with NilVectorSelector when using a vector size larger
than the default and druid.generic.useDefaultValueForNull=false would have the
nulls vector set to all false instead of true
* fixed an overly aggressive check in ExprEval.ofType when handling complex
types which would try to treat any string as base64 without gracefully falling
back if it was not in fact base64 encoded, along with special handling for
complex<json>
* added ExpressionVectorSelectors.castValueSelectorToObject and
ExpressionVectorSelectors.castObjectSelectorToNumeric as convience methods to
cast vector selectors using cast expressions without the trouble of
constructing an expression. the polymorphic nature of the non-vectorized engine
(and significantly larger overhead of non-vectorized expression processing)
made adding similar methods for non-vectorized selectors less attractive and so
have not been added at this time
* more tests more better
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
