imply-cheddar commented on code in PR #13760:
URL: https://github.com/apache/druid/pull/13760#discussion_r1098028649
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/stats/TaskRealtimeMetricsMonitor.java:
##########
@@ -80,6 +85,7 @@ public boolean doMonitor(ServiceEmitter emitter)
thrownAway
);
}
+ builder.setDimensionIfNotNull(DruidMetrics.INGEST_METADATA,
metricMetadata);
Review Comment:
tags?
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorSpec.java:
##########
@@ -132,6 +133,13 @@ public Map<String, Object> getContext()
return context;
}
+ @JsonIgnore
Review Comment:
Why JsonIgnore? Jackson should only be using tagged fields anyway, so just
not tagging it should be sufficient.
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/TaskRealtimeMetricsMonitorBuilder.java:
##########
@@ -45,15 +47,20 @@ public static RealtimeMetricsMonitor build(Task task,
FireDepartment fireDepartm
);
}
- public static TaskRealtimeMetricsMonitor build(Task task, FireDepartment
fireDepartment, RowIngestionMeters meters)
+ public static TaskRealtimeMetricsMonitor build(
+ Task task,
+ FireDepartment fireDepartment,
+ RowIngestionMeters meters
+ )
{
return new TaskRealtimeMetricsMonitor(
fireDepartment,
meters,
ImmutableMap.of(
DruidMetrics.TASK_ID, new String[]{task.getId()},
DruidMetrics.TASK_TYPE, new String[]{task.getType()}
- )
+ ),
+ (Map<String, Object>) task.getContext().get("metricMetadata")
Review Comment:
"tags". On your blowing up comment, write defensive code please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
