zachjsh opened a new pull request, #13766:
URL: https://github.com/apache/druid/pull/13766

   ### Description
   
   This change adds a new config property 
`druid.sql.planner.operatorConversion.denyList`, which allows a user to specify
   any operator conversions that they wish to disallow. A user may want to do 
this for a number of reasons, including security concerns. The default value of 
this property is the empty list `[]`, which does not disallow any operator 
conversions.
   
   An example usage of this property is 
`druid.sql.planner.operatorConversion.denyList=["extern"]`, which disallows the 
usage of the `extern` operator conversion. If the property is configured this 
way, and a user of the Druid cluster tries to submit a query that uses the 
`extern` function, such as the example given 
[here](https://druid.apache.org/docs/latest/multi-stage-query/examples.html#insert-with-no-rollup),
 a response with http response code `400` is returned with en error body 
similar to the following:
   
   ```
   {
     "taskId": "4ec5b0b6-fa9b-4c3a-827d-2308294e9985",
     "state": "FAILED",
     "error": {
       "error": "Plan validation failed",
       "errorMessage": "org.apache.calcite.runtime.CalciteContextException: 
From line 28, column 5 to line 32, column 5: No match found for function 
signature EXTERN(<CHARACTER>, <CHARACTER>, <CHARACTER>)",
       "errorClass": "org.apache.calcite.tools.ValidationException",
       "host": null
     }
   }
   ```
   
   This PR has:
   
   - [x] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [x] added documentation for new or modified features or behaviors.
   - [ ] a release note entry in the PR description.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to