jwitko commented on code in PR #13747:
URL: https://github.com/apache/druid/pull/13747#discussion_r1100573665
##########
helm/druid/templates/broker/deployment.yaml:
##########
@@ -41,11 +41,15 @@ spec:
app: {{ include "druid.name" . }}
release: {{ .Release.Name }}
component: {{ .Values.broker.name }}
- {{- with .Values.broker.podAnnotations }}
annotations:
-{{ toYaml . | indent 8 }}
+ druid.k8s.enablePatching: "true"
+ {{- with .Values.broker.podAnnotations }}
+ {{- toYaml . | nindent 8 }}
{{- end }}
spec:
+ {{- if .Values.broker.serviceAccount.create }}
Review Comment:
I see what you're saying. I have a bit of an opposite experience from you
in terms of what other public widely used charts offer which is why I went this
way but I'm not married to it. I can create a helper definition which does the
above sort of style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
