dampcake commented on code in PR #13747:
URL: https://github.com/apache/druid/pull/13747#discussion_r1103435620
##########
helm/druid/README.md:
##########
@@ -96,10 +96,16 @@ The following table lists the configurable parameters of
the Druid chart and the
| `configVars` | druid configuration variables
for all components | `` |
| `gCloudStorage.enabled` | look for secret to set google
cloud credentials | `false` |
| `gCloudStorage.secretName` | secretName to be mounted as
google cloud credentials | `false` |
+| `rbac.create` | Create roles and roleBindings for
service Accounts | `true` |
| `broker.enabled` | enable broker
| `true` |
| `broker.name` | broker component name
| `broker` |
| `broker.replicaCount` | broker node replicas (deployment)
| `1` |
| `broker.port` | port of broker component
| `8082` |
+| `broker.serviceAccount.create` | Create a service account for
broker service | `true` |
+| `broker.serviceAccount.name` | Service account name
| `true` |
Review Comment:
The documentation looks off to me. Sorry I didn't catch this before. Looks
like it says the default for everything is `true` but that's not actually the
case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
