clintropolis opened a new pull request, #13809:
URL: https://github.com/apache/druid/pull/13809
### Description
This PR removes numeric null value coercion from the expression processing
engine in favor of doing it on the consumer side. This appears to have minimal
impact, since `isNumericNull` will still return false in default value mode,
and numeric operators check this and use the numeric primitive methods of
`ExprEval` instead of `value()`. This walks back some of the changes in #13781.
Backstory, it would be nice to always write null values into segments,
shifting `druid.generic.useDefaultValueForNull` to a query time only setting on
whether or not to use the null value bitmap index when scanning/aggregating
columns. However, I have not made this change yet in this PR.
#### Release note
Null values input to and created by the Druid native expression processing
engine no longer coerce `null` to the type appropriate 'default' value if
`druid.generic.useDefaultValueForNull=true`. This should not impact existing
behavior since this has been shifted onto the consumer and internally operators
will still use default values in this mode, but calling this change to
attention in case any subtle behavior changes around the handling of `null`
values.
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
