clintropolis commented on code in PR #13809:
URL: https://github.com/apache/druid/pull/13809#discussion_r1119974592
##########
processing/src/main/java/org/apache/druid/math/expr/ExprEval.java:
##########
@@ -771,7 +789,7 @@ private static class DoubleExprEval extends NumericExprEval
private DoubleExprEval(@Nullable Number value)
{
- super(value == null ? NullHandling.defaultDoubleValue() : (Double)
value.doubleValue());
+ super(value == null ? null : value.doubleValue());
Review Comment:
ah i was wrong, at least a lot of tests were counting on forced casts, i see
lots of
```
Expected :java.lang.Long<1>
Actual :java.lang.Integer<1>
```
after removing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
