adarshsanjeev commented on code in PR #13808:
URL: https://github.com/apache/druid/pull/13808#discussion_r1109243311
##########
integration-tests-ex/cases/src/test/resources/multi-stage-query/wikipedia_merge_index_msq.sql:
##########
@@ -13,8 +13,8 @@ SELECT
SUM("added") AS "added",
SUM("deleted") AS "deleted",
SUM("delta") AS "delta",
- EARLIEST("user", 128) AS "first_user",
- LATEST("user", 128) AS "last_user"
+ EARLIEST_BY("user", CASE WHEN CAST("timestamp" AS BIGINT) > 0 THEN
MILLIS_TO_TIMESTAMP(CAST("timestamp" AS BIGINT)) ELSE TIME_PARSE("timestamp")
END, 128) AS "first_user",
+ LATEST_BY("user", CASE WHEN CAST("timestamp" AS BIGINT) > 0 THEN
MILLIS_TO_TIMESTAMP(CAST("timestamp" AS BIGINT)) ELSE TIME_PARSE("timestamp")
END, 128) AS "last_user"
Review Comment:
I agree, this isn't a fix, it's a workaround, but the tests that are failing
are not to check for aggregations. This is used for a few tests like
BatchIngest test and ReindexTest, and any aggregation would work for these
tests. Disabling them might make a part of the code untested instead. Should I
disable these tests for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
