paul-rogers commented on code in PR #13808:
URL: https://github.com/apache/druid/pull/13808#discussion_r1110208768
##########
integration-tests-ex/cases/src/test/resources/multi-stage-query/wikipedia_merge_index_msq.sql:
##########
@@ -13,8 +13,8 @@ SELECT
SUM("added") AS "added",
SUM("deleted") AS "deleted",
SUM("delta") AS "delta",
- EARLIEST("user", 128) AS "first_user",
- LATEST("user", 128) AS "last_user"
+ EARLIEST_BY("user", CASE WHEN CAST("timestamp" AS BIGINT) > 0 THEN
MILLIS_TO_TIMESTAMP(CAST("timestamp" AS BIGINT)) ELSE TIME_PARSE("timestamp")
END, 128) AS "first_user",
+ LATEST_BY("user", CASE WHEN CAST("timestamp" AS BIGINT) > 0 THEN
MILLIS_TO_TIMESTAMP(CAST("timestamp" AS BIGINT)) ELSE TIME_PARSE("timestamp")
END, 128) AS "last_user"
Review Comment:
How about this. This test did, in fact, find a bug, so it is useful. But,
the point of the test is actually to exercise something else.
So, maybe comment out the lines that fail. Ensure we have an Apache issue
for the problem. Have that problem point to the test and say that, to see the
bug, just uncomment the lines.
Then, go ahead and add your new lines so that the test passes.
This will achieve the short-term goal (clean test) while also ensuring we
don't forget to fix the underlying issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
