somu-imply commented on code in PR #13799:
URL: https://github.com/apache/druid/pull/13799#discussion_r1116364786
##########
processing/src/main/java/org/apache/druid/segment/UnnestStorageAdapter.java:
##########
@@ -107,15 +105,15 @@ public Sequence<Cursor> makeCursors(
retVal.getColumnSelectorFactory(),
dimensionToUnnest,
outputColumnName,
- allowSet
+ filter
Review Comment:
The filter that appears here will be on the unnested column only. For
example if you are unnesting dim3 to ud3, any filter on ud3 will appear here.
The filter on ud3 cannot be pushed into base but can only be sent to the unnest
cursor as an allow filter. There is scope of optimization here to rewrite the
same filter on dim3 and push it to the base
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
