somu-imply commented on code in PR #13892:
URL: https://github.com/apache/druid/pull/13892#discussion_r1131756550
##########
sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidRel.java:
##########
@@ -95,6 +96,26 @@ public PlannerContext getPlannerContext()
return plannerContext;
}
+ /**
+ * Overridden to ensure that subclasses provide a proper implementation. The
default implementation from
+ * {@link AbstractRelNode} does nothing and is not appropriate.
+ */
+ @Override
+ public RelWriter explainTerms(RelWriter pw)
+ {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ protected Object clone() throws CloneNotSupportedException
+ {
+ // RelNode implements Cloneable, but our class of rels is not cloned, so
does not need to implement clone().
+ throw new UnsupportedOperationException();
Review Comment:
IntelliJ inspections is flagging it as it does not throw a
CloneNotSupportedException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
