somu-imply commented on PR #13892:
URL: https://github.com/apache/druid/pull/13892#issuecomment-1462996702

   Additionally there is a CI failure for this test 
`testGroupByFloatMinExpressionVsVirtualColumnWithExplicitStringVirtualColumnTypedInput`.
   
   The problem seems to trigger from running with 
`-Ddruid.generic.useDefaultValueForNull=false`. The fix for this is to change 
the lines
   ```
   "minVc",
   NullHandling.replaceWithDefault() ? Float.POSITIVE_INFINITY : null
   ```
   with
   ```
   "minVc",
   Float.POSITIVE_INFINITY
   ```
   
   Although I am unsure what caused this to change


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to