vtlim commented on code in PR #13938: URL: https://github.com/apache/druid/pull/13938#discussion_r1137738344
########## examples/quickstart/jupyter-notebooks/druidapi/druidapi/__init__.py: ########## @@ -13,14 +13,14 @@ # See the License for the specific language governing permissions and # limitations under the License. -from .druid import DruidClient +from druidapi.druid import DruidClient Review Comment: Do we have a reason to prefer relative imports? It seems that the [recommended approach](https://peps.python.org/pep-0008/) is absolute imports when possible. >Absolute imports are recommended, as they are usually more readable and tend to be better behaved (or at least give better error messages) if the import system is incorrectly configured (such as when a directory inside a package ends up on sys.path): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
