paul-rogers commented on code in PR #13938:
URL: https://github.com/apache/druid/pull/13938#discussion_r1137771853
##########
examples/quickstart/jupyter-notebooks/druidapi/druidapi/datasource.py:
##########
@@ -32,28 +32,28 @@ class DatasourceClient:
See
https://druid.apache.org/docs/latest/operations/api-reference.html#datasources
'''
-
+
Review Comment:
Vim? Now that's true old-school!
##########
examples/quickstart/jupyter-notebooks/druidapi/druidapi/__init__.py:
##########
@@ -13,14 +13,14 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-from .druid import DruidClient
+from druidapi.druid import DruidClient
Review Comment:
While this may be true of user code, relative imports are often used in
libraries. That's where I first saw them. For example, [in
Requests](https://github.com/psf/requests/blob/main/requests/__init__.py#L45):
```python
from .exceptions import RequestsDependencyWarning
```
From that same quote above:
> However, explicit relative imports are an acceptable alternative to
absolute imports
Also,
> A Foolish Consistency is the Hobgoblin of Little Minds
However, since the code works either way, I suppose it is find to go the
verbose route.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
